Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component nested in if_block will fail to unmount if it has an element using an outro nested in a truthy if_block #4630

Closed
pushkine opened this issue Apr 4, 2020 · 2 comments · Fixed by #4634

Comments

@pushkine
Copy link
Contributor

pushkine commented Apr 4, 2020

This is a concise report for the bug encountered in #4620, #4064, #3685, #3410 and #3202.

Absolute minimum REPL

  1. New Component
    • Declares a variable and a way to change it
    • Has an if_block whose condition is that variable
    • That if_block has an element using the outro directive
    • The variable happens to be truthy
  2. Put Component inside an if_block that turns truthy
    a) if_block depends on a variable
    ✔ Variable was changed from outside the Component
    💥Variable was changed directly from inside the Component through a binding
    b) if_block depends on a store
    ✔ Component does not access that specific store using the $store syntax
    💥Component accesses that store using $store syntax at least once
@pushkine pushkine changed the title Component nested in if_block will fail to unmount if it has an element using outro nested in a truthy if_block Component nested in if_block will fail to unmount if it has an element using an outro nested in a truthy if_block Apr 4, 2020
@JohnRSim
Copy link

JohnRSim commented Apr 7, 2020

@pushkine #4344 - also this will help with ghosting caused by scrolling and dual transitions with crossfade - if it can be reviewed and approved.

@Conduitry
Copy link
Member

Released your fix in 3.21.0 - thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants