Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InputOutputToggle doesn't completely hide the browser checkbox #5116

Closed
lukasmoellerch opened this issue Jul 8, 2020 · 7 comments
Closed

Comments

@lukasmoellerch
Copy link
Contributor

Describe the bug
The InputOutputToggle component doesn't completely hide the browser checkbox on mobile safari, there are still parts of the checkbox that are visible which results in InputOutputToggle looking weird. The rectangle is only visible when the checkbox in its off state.

toggle

Version: AppleWebKit/605.1.15 (KHTML, like Gecko) Version/13.1.1 Mobile/15E148 Safari/604.1

@Conduitry Conduitry transferred this issue from sveltejs/svelte Jul 8, 2020
@lukasmoellerch
Copy link
Contributor Author

@Conduitry I don't quite understand why the issue was moved. I thought that the bug is related to https://github.com/sveltejs/svelte/blob/master/site/src/components/Repl/InputOutputToggle.svelte which is located in the main sveltejs repo. Is it planned to move that component to this repo as well?

@Conduitry
Copy link
Member

Whoops! You are right. I will transfer this back.

@benschac
Copy link
Contributor

I made a PR in site-kit.

@benschac
Copy link
Contributor

Could this be updated to has PR?

@Wolfr
Copy link
Contributor

Wolfr commented Jul 23, 2020

Aha, I was trying to fix this issue but it was already fixed here. I swore I saw a fix but couldn't find it.

In my solution I am simply adding border: none to he code.

@benschac
Copy link
Contributor

Anything else on my end to get this PR to the finish line?

@Rich-Harris
Copy link
Member

Redeployed the site with @benschac's fix 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants