Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

css-unused-selector: Add to message which selector is unused #5252

Closed
dummdidumm opened this issue Aug 8, 2020 · 1 comment · Fixed by #5253
Closed

css-unused-selector: Add to message which selector is unused #5252

dummdidumm opened this issue Aug 8, 2020 · 1 comment · Fixed by #5253

Comments

@dummdidumm
Copy link
Member

Is your feature request related to a problem? Please describe.
The css-unused-selector warning message does not contain the name of the unused selector. Adding this would help in scenarios like svelte-check where people do not see the code but only get a list of warnings/errors.

Describe the solution you'd like
Enhancing the message like this: Unused CSS selector ".bla"

Describe alternatives you've considered
Infer the name from start / end, but this does not map back to original code in a good way (if people are using preprocessors like less/scss)

How important is this feature to you?
Nice to have, not super important but I think it's implemented quickly since you already have the start/end position.

Additional context
Related ticket in language-tools: sveltejs/language-tools#434

@Conduitry
Copy link
Member

In 3.25.0, the warning message now also tells you what the selector is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants