Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated a11y-no-onchange warning #6457

Merged
merged 1 commit into from
Jun 29, 2021

Conversation

geoffrich
Copy link
Member

Removes the a11y-no-onchange compiler warning. See #4946 (comment) for the rationale behind this change. tl;dr: the jsx-a11y rule this warning was based on is now deprecated. The original rationale is from 2004 and no longer an a11y best practice for modern browsers (or even IE11).

My comment on the original issue thread received 20+ positive reactions since I posted it in January, so figured I'd submit a PR to get the ball rolling. If this change is not wanted, feel free to close.

Fixes #4946

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

@Rich-Harris Rich-Harris merged commit e73f641 into sveltejs:master Jun 29, 2021
@Rich-Harris
Copy link
Member

nice, thank you!

@geoffrich geoffrich deleted the remove-a11y-onchange branch June 29, 2021 15:13
@Conduitry
Copy link
Member

Released in 3.39.0 - thanks!

arlandfran added a commit to arlandfran/anime-corner-rankings-old that referenced this pull request Jul 29, 2021
maxlath added a commit to inventaire/inventaire-client that referenced this pull request Oct 6, 2021
removing the need to ignore a11y-no-onchange warnings
thank to sveltejs/svelte#6457
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants