Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inspector — Clicking on a component does not open the corresponding file in the editor on Windows + WSL2 setup #481

Closed
codepainting opened this issue Nov 1, 2022 · 1 comment
Labels
bug Something isn't working triage Awaiting triage by a project member

Comments

@codepainting
Copy link

codepainting commented Nov 1, 2022

Describe the bug

On a Windows + WSL2 setup, the wonderful inspector feature only works partially.
— Highlighting elements works perfectly and components are being recognized correctly.
— But: Clicking on a component does not open the corresponding file in the editor.

The following error messages are being displayed in the terminal:

Could not open +page.svelte in the editor.
Could not open Buttonk.svelte in the editor.

which means, that they are correctly recognized, but not opened.

Adding an .env file with LAUNCH_EDITOR=code variable does not solve the problem.

The issue might or might not be related to the launch-editor, so I mentioned it also over at:
yyx990803/launch-editor#16 (comment)

Reproduction URL

new SvelteKit demo app

Reproduction

  1. Run this on a Windows + WSL2 + VSCode setup.
  2. Create new SvelteKit app.
  3. Enable inspector by adding to svelte.config.js:
vitePlugin: {
	experimental: {
		inspector: {
			toggleKeyCombo: 'control-shift',
			holdMode: true,
			showToggleButton: 'always',
			toggleButtonPos: 'top-right',
		}
	},
}
  1. Run dev server and select some components.
  2. See how the aforementioned errors are being logged to the terminal.

Logs

No response

System Info

System:
    OS: Linux 5.10 Ubuntu 20.04.5 LTS (Focal Fossa)
    CPU: (4) x64 Intel(R) Core(TM) i5-7600K CPU @ 3.80GHz
    Memory: 23.05 GB / 25.02 GB
    Container: Yes
    Shell: 5.8 - /usr/bin/zsh
  Binaries:
    Node: 16.18.0 - ~/.volta/tools/image/node/16.18.0/bin/node
    Yarn: 1.22.4 - ~/.volta/bin/yarn
    npm: 8.19.2 - ~/.volta/tools/image/node/16.18.0/bin/npm
  npmPackages:
    @sveltejs/adapter-auto: next => 1.0.0-next.86 
    @sveltejs/kit: next => 1.0.0-next.531 
    svelte: ^3.46.0 => 3.52.0 
    vite: ^3.1.0 => 3.2.2
@codepainting codepainting added bug Something isn't working triage Awaiting triage by a project member labels Nov 1, 2022
@Conduitry
Copy link
Member

Duplicate of #355. As indicated in that issue, the way to fix this would be upstream in launch-editor, in the issue you linked to.

@Conduitry Conduitry closed this as not planned Won't fix, can't repro, duplicate, stale Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage Awaiting triage by a project member
Projects
None yet
Development

No branches or pull requests

2 participants