Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar no longer visible (sidebar === null) since 0.9 #10

Open
didier opened this issue Apr 18, 2022 · 7 comments
Open

Sidebar no longer visible (sidebar === null) since 0.9 #10

didier opened this issue Apr 18, 2022 · 7 comments

Comments

@didier
Copy link
Contributor

didier commented Apr 18, 2022

Kudos on the quick fixes of all the issues coming in!

Just noticed however, that when updating to 0.9.0, the sidebar no longer shows. There's no error, just nothing. I noticed that changing the formatting function to just return the regular string fixes it. Might be something wrong with the capitalize script.

@didier didier changed the title Sidebar no longer visible (export let sidebar = null) since 0.9 Sidebar no longer visible (sidebar === null) since 0.9 Apr 18, 2022
@mihar-22
Copy link
Contributor

Strange I can't repro. In 0.9.2 I added a debug option to request handlers which may help us uncover what's wrong. Could you please upgrade and try the following in [dir].sidebar.json.js:

import { createSidebarRequestHandler } from '@svelteness/kit-docs/node';

export const get = createSidebarRequestHandler({
  debug: true,
});

Let me know if any error logs in your console after doing so.

@mihar-22
Copy link
Contributor

If this fails, a repro of your exact setup would be help me fix it.

@phenomen
Copy link

phenomen commented Apr 19, 2022

Same here. I just launched kit-docs demo with updated packages and there is no sidebar. debug: true does not show anything.

@mihar-22
Copy link
Contributor

This is really weird, I can't repro...?

@mihar-22
Copy link
Contributor

This might be a Windows specific bug again?

@mihar-22
Copy link
Contributor

If anyone can give me a repro of their exact setup I'll happily try to debug. Let me know what version of Node, if you're using NPM/PNPM (+ version) and anything else that might matter.

@didier
Copy link
Contributor Author

didier commented Apr 20, 2022

@mihar-22 I'll try to make a repro later this week!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants