Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pin create-svelte version to avoid bug like #52 #56

Conversation

stephane-klein
Copy link
Contributor

See #52 (comment)

@mihar-22 what do you think about this Pull Request, to pin create-svelte version to avoid SvelteKit breaking changes.

@mihar-22
Copy link
Contributor

I still don't think we should. Most the breaking changes where from the upgrade to Vite 3 which have cooled down now. I just missed the $app fix when I updated things before.

@stephane-klein
Copy link
Contributor Author

I just missed the $app fix when I updated things before.

@mihar-22 I think you haven't missed $app, in your 22d6a83 dated 2022-07-13, because the SvelteKit breaking change date 2022-07-14, after your fix 🤔.

@stephane-klein
Copy link
Contributor Author

@mihar-22 since 2 weeks, I think I have each day some breaking change. For now, I think it is not possible to use Kit-docs 😭

@mihar-22
Copy link
Contributor

I'm sorry @stephane-klein. I'll have a look today to see if I can get everything working again.

@mihar-22 mihar-22 closed this Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants