-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Migrate docs to SvelteKit and improve them #324
Comments
What are some of the bugs in the search functionality? I could try to fix them |
If I remember correctly, it was the navigation after the search that was problematic. Sorry, I don't remember details and can't test it out right now |
OK, let me check |
I think #337 should fix that issue. Anything else? |
What is the second problem about? |
If you navigate through the docs you can see, there's some delay in some navigation and the scroll becomes broken in some pages |
Another issue is the sidebar, it's using svelte:window to apply the logic but that should be moved to css with media queries |
I tried moving the logic to media queries but one problem was that the transition no longer worked. Is that fine? |
Hum, we can always fix that later |
How exactly is the scroll broken? I could try fixing it |
Not sure if it's something that still happens, but if you scrolled through a page then navigated, there was a situation where the page would appear cut, even when scrolling up |
I tried reproducing this error but I still haven't been able to see it. Maybe one of the fixes to the slashes or something fixed it? |
Yap, let's ignore that for now, I don't think I was able to reproduce it as well now |
Updated the issue description with the update on what's missing, so that it does not get lost |
@Caladan08 Dark theme for docs is basically done. Updated the description of the issue with what is missing |
Relating to the styling in the code blocks, is it fine if we use a highlighter like shiki in the docs? I've tried implementing it and it looked quite good. There was only one problem regarding to the CodeDemo in the Configurator components in |
The problem is that it should not be necessary, mdsvex should already do the highlighting. There's some kind of bug happening where it's not applied. |
Yeah, I noticed the same. Some times, the highlighting would appear but majority of the time, it didn't |
I think it might be a problem with Prism, since we also use it in the demos configurator...perhaps some conflict with the stylings...still have to investigate it further |
@Caladan08 Fixed! 👍 We were not importing the correct highlight stylesheet.
|
The ComponentsExample mobile layout appears because the |
Even after enabling SSR in the SvelteUIProvider and only using the |
@Caladan08 The solution must be through media queries, since it's the only way without javascript. Yeah, probably a lot of duplicated code. We can always refactor later, though |
Any idea why the ComponentExamples is rendering in this broken form? Even the Tabs are not being rendered properly. This happened after I removed all the references to orientation={windowWidth < 1075 ? 'horizontal' : 'vertical'}
variant="unstyled"
position={windowWidth < 1075 ? 'center' : 'left'} Screen.Recording.2023-04-28.at.10.26.17.PM.mov |
Ok, that is weird. I'll need to take a closer look, since I'm not sure what is happening. For now, I would remove the desktop style and just set the tabs as in mobile (tabs above the content instead of to the left) and align them to the left perhaps. It can simplify all this logic and still look alright |
@Caladan08 I made some big changes in the structure of the docs. Basically they came from troubles prerendering the docs as they were. I've also tried it out on my own GH pages, it seems like it worked well. I think it's basically done, just ironing out some small stuff. |
It's been a pleasure working with you as well. Thanks for all the help 👏 |
It's been merged and deployed! 🥳 Great work @Caladan08, thank you again! |
It looks amazing 🎉🎉 |
Usage example, including component, action, motion, or utility API
Right now our docs are problematic:
Possible implementation - describe how the feature can be implemented
There is already a migration started by @Caladan08 in branch https://github.com/svelteuidev/svelteui/tree/docs-sveltekit-migration, which already has a working version of the current docs. There are still problems to be fixed
Tab
(navigation with arrow keys could also be an improvement)This can also be an opportunity to re-design and overall improve the experience and content of the docs. We are open to ideas and contributions to improve our docs.
Do you want to contribute this feature and create a pull request
Yes
The text was updated successfully, but these errors were encountered: