Provide a description for MARTINS_TAG. Its the same as MARTINS_DAY, but #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in Austria and Bavaria its translated to "Martini". MARTINS_TAG is used in Austria/Burgenland for the 11.11.
|
Could you please also provide translations for the other languages. Even if its the same name. Thanks. |
|
Done. |
|
thanks, but you don't use the new translations for the holidays, do you? could you also make the changes to the holiday files where the holiday is called by the new name? thank you. |
|
This only affects Austria (i.e. src/main/resources/holidays/Holidays_at.xml). Which already uses MARTINS_TAG in master. What resources should I modify additionally? Sorry, don`t get it. |
svendiedrichsen
added a commit
that referenced
this pull request
Aug 25, 2015
Provide a description for MARTINS_TAG. Its the same as MARTINS_DAY, but
|
I thought you meant the day was also a holiday in bavaria. pulled your changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in Austria and Bavaria its translated to "Martini". MARTINS_TAG is used
in Austria/Burgenland for the 11.11.
BTW: Are you planning a release of 0.5.2 anytime soon?