Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Germany: Reformationstag as one-time public holiday #32

Closed
jschrod opened this issue Jun 29, 2016 · 5 comments · Fixed by #34
Closed

Germany: Reformationstag as one-time public holiday #32

jschrod opened this issue Jun 29, 2016 · 5 comments · Fixed by #34

Comments

@jschrod
Copy link

jschrod commented Jun 29, 2016

2017 we will have Reformationstag (2017-10-31) as public holiday in all of Germany, but only that year.
I suppose one has to add a Fixed entry with validFrom and validTo at the top of Holidays_de.xml.
Is this already in the works or do you want a pull request?

Cheers, Joachim

@svendiedrichsen
Copy link
Owner

Would be very nice of you if you could create a pull request for this. Thanks in advance.
Cheers, Sven

@GeBeater
Copy link
Contributor

GeBeater commented Jul 6, 2016

Pull request #34 created.

@jschrod
Copy link
Author

jschrod commented Jul 6, 2016

OK; a pull request within 16 minutes, while I'm watching semifinals; beats me. You're both obviously no football fans. :-) :-)
Thanks a lot, Bernd and Sven!!

@opensource21
Copy link
Contributor

Any chance that a new version will be published? We now have 2017 and in 2018 the patch is useless.

@svendiedrichsen
Copy link
Owner

svendiedrichsen commented Jan 10, 2017

released 0.5.2 - but you don't have to wait for a release to have an updated calendar. simply have your own delivered with your app and use this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants