New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Where is the package "de.jollyday.config" on GitHub? #59
Comments
Okay, it is dynamically created via xml-binding but I still see the disadvantage not to have reasonable good javadocs and source code navigation. Question: Is excluding the package from javadoc really necessary?
|
Classes under |
I see your point. So that package is some kind of implementation internals. But I also still see the problem that other parts of public API refer to the package IMHO, a public API should not refer to internals. This has first made it difficult for me to understand your API, and introducing new public interfaces might solve the problem, but of course, you are free to close this issue without action if it is too much work for you. |
I'm open to any suggestions. Please feel free to fork and rework apropriately. |
Okay, I will try to make some proposals in code form later (but probably rather in the begin of year 2018 when I can also contribute holidays in Israel). |
By the way, have you noticed that Oracle seems to be willing to delete the
Here an official link: http://openjdk.java.net/jeps/320 It would probably affect Jollyday so I thought it is good for you to know for the future. |
Thank you. Good to know. |
Some classes like
EthiopianOrthodoxHolidayParser
refer to the package (for example to the classde.jollyday.config.Holidays
) but I cannot find the package - neither on GitHub nor on downloaded zip-files from GitHub. I think, an open-source-project is supposed to contain all source code, or have I overlooked something?Background is, I would like to contribute for example Hebrew holidays in the future but then I need to see and understand the whole source code...
The text was updated successfully, but these errors were encountered: