Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add holidays for New Zealand #60

Merged
merged 1 commit into from Dec 13, 2017
Merged

Add holidays for New Zealand #60

merged 1 commit into from Dec 13, 2017

Conversation

tenjaa
Copy link
Contributor

@tenjaa tenjaa commented Dec 13, 2017

Hey,

I saw New Zealand was missing, so I added the statutory holidays as described in the law.
Wikipedia summarizes them also pretty nice.

While writing this, I just saw that DAY_AFTER_NEW_YEAR and WAITANGI are unique, so I will add some translations for them.

And I copied from gb as you can see.. Will fix it too

Please tell me if I missend anything!

References:
http://www.legislation.govt.nz/act/public/2003/0129/latest/DLM237120.html#DLM237120
https://en.wikipedia.org/wiki/Public_holidays_in_New_Zealand

@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.533% when pulling b78c3f6 on tenjaa:master into 3ee3df6 on svendiedrichsen:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.533% when pulling a51b853 on tenjaa:master into 3ee3df6 on svendiedrichsen:master.

@tenjaa
Copy link
Contributor Author

tenjaa commented Dec 13, 2017

Everything I saw should be fixed.

Waitangi Day is never translated if you look through Wikipedia or the rest of the internet. So I left it as it is in every language.

Would be cool to get some feedback :)

@svendiedrichsen svendiedrichsen merged commit bb09de4 into svendiedrichsen:master Dec 13, 2017
@svendiedrichsen
Copy link
Owner

@tenjaa As far as I can tell it looks very good. Thank you very much.

@tenjaa
Copy link
Contributor Author

tenjaa commented Dec 13, 2017

Cool! 👍

Do you have an idea when to release the next version and we can expect these changes on maven central?

@svendiedrichsen
Copy link
Owner

I had no plans but I will do it any day soon now.

@svendiedrichsen
Copy link
Owner

0.5.3 is released. Have fun.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants