Use System.getProperty instead of System.getProperties #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use System.getProperty to get a specific property instead of first
retrieving all properties with System.getProperties() only to read one
property out of it.
This is more friendly to security managers: instead of requiring the
permission to read and even write all properties
("java.util.PropertyPermission" "*" "read,write"), the policy only needs
to allow reading a specific property, which is much more secure.
Depending on the JVM implementation, System.getProperty can also be more
efficient.
kkofler
force-pushed
the
security-policy-friendliness
branch
from
1681e55
to
833cf23
Compare
|
(The force-push changed the From address to my work address, I accidentally had the wrong address set.) |
|
@kkofler Good point. Thanks very much for the PR. |
|
Are you going to do a new release soon? |
|
I just made one. |
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use System.getProperty to get a specific property instead of first
retrieving all properties with System.getProperties() only to read one
property out of it.
This is more friendly to security managers: instead of requiring the
permission to read and even write all properties
("java.util.PropertyPermission" "*" "read,write"), the policy only needs
to allow reading a specific property, which is much more secure.
Depending on the JVM implementation, System.getProperty can also be more
efficient.