Added REFORMATION_DAY for Schleswig-Holstein. #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On 22nd of Feb 2018 the Landtag in Schleswig-Hostein has decided to add the reformation day as an offical holiday in Schleswig-Holstein: http://www.landtag.ltsh.de/plenumonline/archiv/wp19/09/debatten/07_12.html
|
Checks failed. I guess I need to revise first and take a look at the unit tests and xsd... |
|
...just had to fix the failing unit test. |
svendiedrichsen
requested changes
Feb 28, 2018
There was a problem hiding this comment.
@dusiema Please add validFrom=2018 if the holiday is first observed in 2018.
| @@ -110,4 +110,9 @@ | |||
| <tns:Fixed month="OCTOBER" day="31" descriptionPropertiesKey="REFORMATION_DAY"/> | |||
| </tns:Holidays> | |||
| </tns:SubConfigurations> | |||
| <tns:SubConfigurations hierarchy="sh" description="Schleswig-Holstein"> | |||
| <tns:Holidays> | |||
| <tns:Fixed month="OCTOBER" day="31" descriptionPropertiesKey="REFORMATION_DAY"/> | |||
There was a problem hiding this comment.
@dusiema We need a validFrom=2018.
| <tns:Holidays> | ||
| <tns:Fixed month="OCTOBER" day="31"/> | ||
| </tns:Holidays> | ||
| </tns:SubConfigurations> |
There was a problem hiding this comment.
@dusiema This will probably not be nessessary if the validFrom=2018 is added.
|
Sorry, I did not notice your editing request for |
|
I will check the news and add them when they are decided upon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On 22nd of Feb 2018 the Landtag in Schleswig-Hostein has decided to add
the reformation day as an offical holiday in Schleswig-Holstein:
http://www.landtag.ltsh.de/plenumonline/archiv/wp19/09/debatten/07_12.html