Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed tests for stored procs #252

Merged
merged 1 commit into from Nov 20, 2016

Conversation

chipairon
Copy link
Contributor

On backends that store procs on translations, the context is lost (source_file and line) so they can only access methods fully qualified to be 'findable on evaluation'.

I have updated the i18n-active_record gem and it has now at 100% test success on my branch svenfuchs/i18n-active_record#52

From that test suite, the test defined here are executed and this change is needed to support proc storing.

…need to be fully qualified to be 'findable' when being evaluated.
@radar
Copy link
Collaborator

radar commented Nov 20, 2016

LGTM. Thanks @chipairon!

@radar radar merged commit 5e1af91 into ruby-i18n:master Nov 20, 2016
@radar radar added this to the 0.8.0 milestone Nov 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants