Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

locale filter breaks url generation #10

Closed
ZenCocoon opened this issue Sep 9, 2010 · 4 comments
Closed

locale filter breaks url generation #10

ZenCocoon opened this issue Sep 9, 2010 · 4 comments

Comments

@ZenCocoon
Copy link
Contributor

Hi Sven,

Looks like the URL generation helpers are broken as they always requires one parameter :
Error can be found at : http://gist.github.com/571591

I've tested with routing_filter gem 0.1.6, rails 2.3.9 and ruby 1.8.7/1.9.2 rc_2

I've setup a minimal app to show off the issue, please check:
http://github.com/ZenCocoon/test_routing_filter

Thanks for your great work,

@glongman
Copy link

yep, I see this too

@samlown
Copy link

samlown commented Nov 19, 2010

Adding the :locale to the default url options in your application controller gets around this problem:

def default_url_options(options = {})
  { :locale => I18n.locale }
end

Also make sure its a public method, i.e. not below a protected or private.

sam

@svenfuchs
Copy link
Owner

Should be done with this commit 151adea

Can anybody confirm this?

@ZenCocoon
Copy link
Contributor Author

That works fine in my case and with the test app. Thanks for the bug fix.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants