added support for rubies > 1.9.3 #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| gem "ruby_parser", ">= 3.0.1" | ||
| gem 'sexp_processor', ">= 4.3.0" | ||
| gem 'ruby2ruby', ">= 2.0.6" | ||
| gem "ruby_parser", ">= 3.2.0" |
There was a problem hiding this comment.
Are the ruby2ruby/ruby_parser updates necessary? I guess otherwise you'd have to support both styles, right?
There was a problem hiding this comment.
ruby_parser for sure, as the fix isn't backwards-compatible with older versions of ruby_parser. ruby2ruby depends on ruby_parser, so I'd rather update them both. Similar logic re: sexp_processor.
|
If there are no objections, I'm going to merge this and release the new version of the gem sometime tomorrow. |
dmitri-d
added a commit
that referenced
this pull request
Dec 17, 2014
added support for rubies > 1.9.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ruby_parser changed how they handle module constants -- parse tree now looks like:
s(:colon2, s(:const, :Encoding), :UTF_8).This PR fixes the issue.
Note that I removed Gemfile.lock, as it was hiding the issue above (seattlerb/ruby_parser@0a9da94 was committed more than a year ago). Not sure if it's worth pinning minor versions of dependencies in the Gemfile -- I only updated existing constraints.