Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated to use latest version of ruby_parser, ruby2ruby, and sexp_processor #4

Merged
merged 1 commit into from Nov 13, 2012

Conversation

dmitri-d
Copy link
Member

and added support for ruby 1.9.3

svenfuchs added a commit that referenced this pull request Nov 13, 2012
updated to use latest version of ruby_parser, ruby2ruby, and sexp_processor
@svenfuchs svenfuchs merged commit ce2f699 into theforeman:master Nov 13, 2012
@svenfuchs
Copy link
Contributor

Merged without really testing this out, because unfortunately I don't have the time to really maintain this repo.

Interested in taking this over?

@ohadlevy
Copy link
Member

👍 to release a new version with this change?

@lzap
Copy link
Member

lzap commented Nov 22, 2012

I am also interested on getting safemode on 1.9 ;-)

@ohadlevy
Copy link
Member

ohadlevy commented Dec 3, 2012

@svenfuchs if you don't have time, would you allow us to release a new gem?

@svenfuchs
Copy link
Contributor

@ohadlevy of course, just made you a collaborator. can you please tell me your rubygems email so i can make you an owner there, too

@ohadlevy
Copy link
Member

ohadlevy commented Dec 3, 2012

@svenfuchs thanks! its ohadlevy@gmail.com

@lzap
Copy link
Member

lzap commented Dec 3, 2012

Guys, I am not sure where the code is going to live. @ohadlevy you have forked into theforeman/safemode and @svenfuchs made you collaborator on this repository (?) so where should we file PRs? :-)

@ohadlevy
Copy link
Member

ohadlevy commented Dec 5, 2012

@svenfuchs rubygems.org ping ?

@svenfuchs
Copy link
Contributor

@ohadlevy sorry, missed your last comment. and wow! i just noticed that i'm not even the owner of this gem on rubygems.org (http://rubygems.org/gems/safemode), @kronn is.

hey, @kronn could you please add me (svenfuchs@artweb-design.de) as well as @ohadlevy (ohadlevy@gmail.com) as owners to the safemode gem on rubygems?

gem owner -a svenfuchs@artweb-design.de safemode
gem owner -a ohadlevy@gmail.com safemode

thanks :)

@svenfuchs
Copy link
Contributor

@lzap sorry, i didn't even realize there's progress in some fork :)

@kronn
Copy link
Collaborator

kronn commented Dec 5, 2012

@svenfuchs @ohadlevy sorry, missed that also...

You both are added as owners.
BTW thanks again to the former "owner" of the gem, Kingsley Hendrickse, for giving the name to me (and now indirectly: you)

@kronn
Copy link
Collaborator

kronn commented Dec 5, 2012

I think that either this repo should be the main one, so that sven gives everyone collaboration rights.

@svenfuchs
Copy link
Contributor

thank you very much, sir @kronn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants