Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default decode and extract options #200

Closed
BrajBliss opened this issue Jul 10, 2023 · 15 comments · Fixed by #351
Closed

Default decode and extract options #200

BrajBliss opened this issue Jul 10, 2023 · 15 comments · Fixed by #351
Assignees
Labels
feature New feature or request

Comments

@BrajBliss
Copy link

An option to enable these before importing an URL so we don't have to always turn these options on or off.

@svenjacobs
Copy link
Owner

Hello @vrindavan,

do you have an example of a URL that always needs to be decoded? Of course what I could do is remember the states of these toggles.

@BrajBliss
Copy link
Author

BrajBliss commented Jul 10, 2023

I was referring to all URLs in general. You can consider the Spotify or Threads URL for instance (previous issues). An option to remember states would be better.

I use Twitter and Spotify URLs mostly.

Another threads URL if you need: - https://www.threads.net/t/Cugs0gYJcaH/?igshid=NTc4MTIwNjQ2YQ==

@svenjacobs
Copy link
Owner

Just to be clear: The "decode" toggle means to decode an URL which was URL encoded. See #49 why this was added. Usually this option is not required.

@BrajBliss
Copy link
Author

Sure. I was talking about extract only.

@svenjacobs svenjacobs self-assigned this Aug 25, 2023
@svenjacobs svenjacobs added the feature New feature or request label Aug 25, 2023
@serrq
Copy link

serrq commented Sep 14, 2023

Also my RSS reader breaks the ***** with article title + url (merged).

@svenjacobs
Copy link
Owner

Also my RSS reader breaks the ***** with article title + url (merged).

Sorry I don't understand. How is this related to the decode and extract toggles?

@serrq
Copy link

serrq commented Sep 14, 2023

Also my RSS reader breaks the ***** with article title + url (merged).

Sorry I don't understand. How is this related to the decode and extract toggles?

I allude to the extraction of the url. Sometimes it happens that my RSS reader sends in the function "share" title and url together.

Did I misunderstand you?

@serrq
Copy link

serrq commented Sep 14, 2023

Of course the share function send the result to the default browser (Leon). Understand?

@svenjacobs
Copy link
Owner

Could you please provide an example of the text that your RSS shares and what Leon does with it. When you use "extract", does it not work as expected?

@serrq
Copy link

serrq commented Sep 14, 2023

Give me a minute. It works fantastically, but with manual action, not by default.

I have to turn switch ON manually. Not a problem!

@serrq
Copy link

serrq commented Sep 14, 2023

Japan, Canada to develop North American EV battery supply chains
https://asia.nikkei.com/Spotlight/Supply-Chain/Japan-Canada-to-develop-North-American-EV-battery-supply-chains2

1000040438

@myuseraccount
Copy link

So, is it supposed to remember the toggle I selected for "Extract only URL" the last time I shared a URL to the app? Because I just did the following:

  1. sent link from email to URL cleaner using share function
  2. toggled "extract only URL" to on
  3. sent a second link, from browser, using share to URL cleaner
  4. "extract only URL" was observed to be toggled off

@svenjacobs
Copy link
Owner

@myuseraccount This issue is about remembering the toggle states, that's correct. Unfortunately it has not been implemented yet.

@svenjacobs
Copy link
Owner

This has been resolved and will be available in the next release.

@myuseraccount
Copy link

Thank you! The app works great, this will just make it slightly fewer steps to get the result I want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants