New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Aliexpress sanitizer #94
Conversation
Copy paste from the EbaySanitizer, first version to figure out the inner workings
It seems I need to adjust the GHA workflow for contributions. I use git-secret to encrypt files that are required for deployment to Play Store. However the PGP key is obviously not available in workflow runs of contributors. |
That's fine, I'll try out my branch first, then give you feedback. It's still draft, so that's OK to fail Maybe you can add a condition in the workflow if this is a pull request by a contributor for that job? |
Please rebase on |
There has been at least one |
Will do, I have to try it this evening. |
Sure, no stress 😉 |
The build is fixed. It might already work on paper/CI :) |
I tested it with the debug version of this CI run and it works smoothly. Product pages are getting cleaned, all other pages do not seem to have tracking params. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you very much 😃
Copy paste from the EbaySanitizer, first version to figure out the inner workings
Closes #91