Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The error/warning logs that appear in integration test is pretty annoying #120

Closed
KSXGitHub opened this issue May 18, 2019 · 1 comment
Closed

Comments

@KSXGitHub
Copy link
Contributor

KSXGitHub commented May 18, 2019

The test logs does not show them before due to miniserve's logs being disabled by default. But now they are shown alongside normal test logs makes it hard to read the logs that actually matters.

Screenshot of my terminal

Suggestion

Do not redirect stderr output of subprocess to parent's stderr.


P.S. I am not familiar with std::process so I am going to waiting for someone else to do it.

@svenstaro
Copy link
Owner

I didn't notice this before but I entirely agree. This is annoying to read.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants