Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Divide tests/cli.rs into multiple files #85

Closed
KSXGitHub opened this issue Apr 26, 2019 · 4 comments · Fixed by #91
Closed

Divide tests/cli.rs into multiple files #85

KSXGitHub opened this issue Apr 26, 2019 · 4 comments · Fixed by #91

Comments

@KSXGitHub
Copy link
Contributor

The more features miniserve provides, the longer the file get.

@svenstaro
Copy link
Owner

Yes, this should eventually be done.

@svenstaro
Copy link
Owner

svenstaro commented Apr 27, 2019 via email

@KSXGitHub
Copy link
Contributor Author

Did you take a look a look at our current integration tests? Since those do binary integration tests.

Of course I did. What do you mean exactly?

@KSXGitHub
Copy link
Contributor Author

@boastful-squirrel No known programming language in existence can achieve what you described. And integration tests weren't meant to do that either. Integration tests are meant to act as a user, use the program like a user, and expect to see what a user sees. So you are not meant to access ContextualError as a Rust objects, only as a string. For Rust objects, you should use unit tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants