Question: In src/errors.rs, why are ContextualErrorKind and ContextualError declared separately?

[KSXGitHub]

In src/errors.rs, I see ContextualError being a wrapper of ContextualErrorKind, is there a reason of this?

[svenstaro]

It's this pattern: https://rust-lang-nursery.github.io/failure/error-errorkind.html

[KSXGitHub]

Given its high maintenance cost, and its convoluted usage (Err(ContextualError::new(ContextualErrorKind::<name>(...)))), I don't see the advantage of this pattern.

[svenstaro]

@boastful-squirrel did this part so maybe they can provide some insight here.

[ghost]

That's from when I was using failure's context() method, see the link that @svenstaro posted. Now that I don't use the context() feature anymore, all methods could return a ContextualErrorKind and you could simply write ContextualErrorKind::<name> everywhere.

The reason I didn't remove the ContextualError type yet is because I keep playing with failure to see if there is a way to have the errors the way they are now using failure's context, but well, still not yet.

So if @svenstaro agrees, we could totally drop those calls everywhere. If so, should I include that in my current PR ? While I'm a it... Or another one ?

EDIT: you already did it, cool

[svenstaro]

In that case, sure, go ahead.

…

On Sat, Apr 27, 2019, 11:43 Boastful Squirrel ***@***.***> wrote: That's from when I was using failure's context() method, see the link that @svenstaro <https://github.com/svenstaro> posted. Now that I don't use the context() feature anymore, all methods could return a ContextualErrorKind and you could simply write ContextualErrorKind::<name> everywhere. The reason I didn't remove the ContextualError type yet is because I keep playing with failure to see if there is a way to have the errors the way they are now, but well, still not yet. So if @svenstaro <https://github.com/svenstaro> agrees, we could totally drop those calls everywhere. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#87 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAANAHYQNX34JRAFFD5N5LPSQN4JANCNFSM4HI3SZ3A> .