[fix] Sorting breaks subdir downloading #991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Small check in render.rs make_link_with_trailing_slash to return nothing if link is empty, instead of adding a /
|
Thanks! Fix is fine as is. |
|
Awesome, thank you for making this awesome project! |
|
Happy you like it. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a small check in
render.rsmake_link_with_trailing_slashto do nothing if link is empty, instead of adding a slash where its not needed.It looks like nothing calls make_link_with_trailing_slash with an empty string aside from downloading when sorting, so this should not break anything else.
You can test the fix out here if needed: https://archive.vamist.dev/
Another alternative fix is to just not include sorting options when downloading, so if you would rather this, let me know.
Fixes #967