Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] All release tags are created on master #63

Closed
Aytackydln opened this issue Feb 2, 2022 · 2 comments · Fixed by #46
Closed

[BUG] All release tags are created on master #63

Aytackydln opened this issue Feb 2, 2022 · 2 comments · Fixed by #46

Comments

@Aytackydln
Copy link

I want my dev branch to make prereleases but it still creates the release tags on master. This step should specify branch or commit while releasing.

target_commitish needs to be specified while making release. This can be an optional parameter, too.
@Aytackydln Aytackydln changed the title All release tags are created on master [BUG] All release tags are created on master Feb 2, 2022
@illusion0001
Copy link

I think this is what #46 is solving, but it has not been merged yet

@Hiroshiba
Copy link

Hiroshiba commented Aug 20, 2022 •
edited

I faced the same issue.
The proposed pull request does indeed seem to solve this issue.
I hope you merge it! @svenstaro

@Hiroshiba Hiroshiba mentioned this issue Aug 20, 2022
Closed
@rawlins rawlins mentioned this issue Sep 12, 2022
Merged
@Spikatrix Spikatrix mentioned this issue Jun 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow setting an explicit target_commitish Spikatrix/upload-release-action
3 participants
@Hiroshiba @Aytackydln @illusion0001