LLVM assertion: "Initializer type must match GlobalVariable type"

[251]

Hi,

I updated to LLVM 15 (with assertions enabled) and whatever I run ends up in an assertion, e.g.:

int main(void) {}

$ wpa -ander -svfg -dump-icfg test.bc
wpa: /llvm/lib/IR/Globals.cpp:471: void llvm::GlobalVariable::setInitializer(llvm::Constant*): Assertion `InitVal->getType() == getValueType() && "Initializer type must match GlobalVariable type"' failed.

I attached gdb and the issue seems to be that:
https://github.com/SVF-tools/SVF/blob/fa0d081299fd2ace031469a630f00904ba1ee42f/svf-llvm/lib/LLVMUtil.cpp#L511C1-L511C33
causes a type mismatch: newCA (InitVal in LLVM) has type [0 x { ptr, ptr, ptr, i32, ptr }] zeroinitializer whereas glob has the type [217 x { ptr, ptr, ptr, i32, ptr }] (the annotation array).

[yuleisui]

@shuangxiangkan could you take a look at this case?

[shuangxiangkan]

@251 Could you upload the bc file?

[251]

Sure: test.zip. But keep in mind that assertions in LLVM have to be enabled, for distribution packages this is typically not the case.

[JanWichelmann]

I ran into the same problem today. I managed to fix it by reverting this change, i.e., I replaced

glob->setInitializer(newCA);

by

auto globName = glob->getName();
glob->setName("llvm.global.annotations_old");

GlobalVariable *newGlob = new GlobalVariable(*module, annotationsType, glob->isConstant(), glob->getLinkage(), newCA, globName, glob, glob->getThreadLocalMode());
newGlob->setSection(glob->getSection());
newGlob->setAlignment(glob->getAlign());

glob->replaceAllUsesWith(newGlob);
glob->eraseFromParent();

in svf-llvm/lib/LLVMUtil.cpp.

[shuangxiangkan]

@251 @JanWichelmann This issue should have been fixed in #1420.

[JanWichelmann]

Works for me, thank you!