Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong default value for cx, cy on radial gradient #397

Closed
pablojmp opened this issue Jan 2, 2019 · 2 comments
Closed

Wrong default value for cx, cy on radial gradient #397

pablojmp opened this issue Jan 2, 2019 · 2 comments
Labels

Comments

@pablojmp
Copy link

pablojmp commented Jan 2, 2019

If you use a radial gradient server with cx = 0 or cy = 0 the library won't persist the attributes when writing to a file because SvgDefaults.IsDefault will return true.
I'm guessing that these defaults where intended for SvgCircle, and this happens because the SvgRadialGradientServer attributes have the same name (the defaults for SvgRadialGradientServer are 50% for both cx and cy).
Perhaps the Dictionary in SvgDefaults could be something like Dictionary<Type,Dictionary<string,string>>, so the Type could be taken into account when searching for defaults? Or any class with default values could handle it's own defaults...

@pablojmp
Copy link
Author

pablojmp commented Jan 2, 2019

Thanks for the awesome work, btw!

@mrbean-bremen
Copy link
Member

Thanks for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants