-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using grunt-svg-sprite @ 1.2.1 stop working #54
Comments
Small correction: we were working with grunt-svg-sprite "1.1.2" version, and didn't change that. Seems it was suddenly fetching a newer version of svg-sprite as well. |
No idea why your installation seems to have auto-updated itself, but the tests for the latest version that i released 2 hours ago were running fine. Have done a full update in the meantime to pull in all the latest dependencies? |
I did make a full update, and then it started to reproduce.. |
Ah, and something more: I remember having had a similar issue in the past, where the reason finally was an SVG source file that was not a (valid) SVG file. I'm only on my mobile right now and can't search effectively, but you might find the case in the (grunt-/gulp-)svg-sprite issues. I did a small tweak on the regular expression that tries to identify non-valid SVG files. Maybe I thus introduced a regression which makes your workflow blow up. But again, the reason would be an invalid source file ... |
We didn't make any changes to our source files. Another thing that may help - note that we were only depended on:
In order to overcome this issue we added:
Maybe the grunt-svg-sprite dependency of svg-sprite was changed, but this shouldn't be done without changing the version of grunt-svg-sprite itself, IMO. |
Could you please send me your complete Grunt task config and package.json dependencies (and possibly your SVG files) to joschi [at] kuphal [dot] net? I'll try to have a look at it later today or tomorrow. As I said, the build was passing fine, there must be wrong something else ... |
Thanks, I'll send it. |
One last thing which isn't yet clear to me: Did you also try to update the grunt-svg-sprite version to the latest 1.2.1 (and run a full |
We only had grunt-svg-sprite on our package.json file, using version 1.1.2. Yesterday, it started to bring svg-sprite 1.2.1 (and still grunt-svg-sprite 1.1.2). So, as a workaround, we added to our package.json file that we should use svg-sprite 1.1.2. |
Ok, so you've still got grunt-svg-sprite 1.1.2 in your Could you please update that to 1.2.2 (there has been another new release in the meantime) and run Btw thanks for sending me your dependencies. However, without your task setup and the SVG files themselves there's nothing I could do. As I said, I suggest a problem with one of your icons (which didn't have any effect before). |
Yes, I still got grunt-svg-sprite 1.1.2 in my package.json file. What I don't understand - how come, from yesterday, we suddenly started to get svg-sprite 1.2.1, without doing any change to SVG files or package.json. I think we are ok with 1.1.2, unless there is a real reason to upgrade? As I said, now we also have svg-sprite in package.json, pointing to 1.1.2. This solved the issue. |
→ I don't understand this as well. As long as you don't trigger
→ Exactly that's the real reason to upgrade. Until yesterday, grunt-svg-sprite's dependency setting was However, the real problem is the error message you get when running the task. Please, let me know if it disappears after upgrading. |
On each build we do "npm install" on a clean, fresh (no npm cache) VM environment. Because grunt-svg-sprite was using svg-sprite ^1.1.2, it may explain that... |
I guess you simply cannot. However, your original issue should be solved (or at least solvable) now, right? I'll close this one for now, but please feel free to reopen it in case of further problems. Cheers, Joschi |
In the last hour, we started to get this exception:
Seems that although we didn't change the grunt-svg-sprite version, some inner dependencies changed (specifically - the async and svgo).
Here is a comparison:
Failing:
svg-sprite@1.2.1 (cssmin@0.4.3, css-selector-parser@1.0.4, xmldom@0.1.19, mustache@2.0.0, cssom@0.3.0, xpath@0.0.9, mkdirp@0.5.1, glob@5.0.10, vinyl@0.5.0, async@1.2.0, js-yaml@3.3.1, yargs@3.10.0, winston@1.0.0, phantomjs@1.9.17, svgo@0.5.2, lodash@3.9.3)
Success:
svg-sprite@1.1.2 (cssmin@0.4.3, css-selector-parser@1.0.4, xmldom@0.1.19, async@0.9.2, mustache@2.0.0, cssom@0.3.0, xpath@0.0.9, vinyl@0.4.6, mkdirp@0.5.1, glob@5.0.10, js-yaml@3.3.1, winston@1.0.0, lodash@3.9.3, yargs@3.10.0, svgo@0.5.0, phantomjs@1.9.17)
Any help?
The text was updated successfully, but these errors were encountered: