Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid Sass syntax for background images #125

Closed
binarykitchen opened this issue Dec 1, 2015 · 9 comments
Closed

Invalid Sass syntax for background images #125

binarykitchen opened this issue Dec 1, 2015 · 9 comments
Assignees

Comments

@binarykitchen
Copy link

It produces this

%svg-common {
    background: url(svg/sprite.css.svg) no-repeat;
}

but should be in quotes like this:

%svg-common {
    background: url("svg/sprite.css.svg") no-repeat;
}
@jkphl jkphl closed this as completed in 6441511 Dec 1, 2015
@jkphl jkphl self-assigned this Dec 1, 2015
@jkphl
Copy link
Collaborator

jkphl commented Dec 1, 2015

@binarykitchen Wrapping url() values in quotes is recommended, but omitting them is not considered an error (see spec):

For legacy reasons, a can be written without quotation marks around the URL itself. This syntax is specially-parsed, and produces a rather than a function syntactically. [CSS3SYN]

However, as there have been some problems with unquoted values especially on Windows in the past (IIRC), I just introduced quotes in all places. Thanks for reporting!

@binarykitchen
Copy link
Author

Good. When will you npm publish that?

@jkphl
Copy link
Collaborator

jkphl commented Dec 1, 2015

@binarykitchen Happened about 12 hours ago ;)

@binarykitchen
Copy link
Author

@jkphl cool and its gulp module?

@jkphl
Copy link
Collaborator

jkphl commented Dec 1, 2015

@binarykitchen Pls have a look at the release info https://github.com/jkphl/gulp-svg-sprite/releases

@binarykitchen
Copy link
Author

hmmm, somehow i fail to install this version:

~/D/smx3-frontend ❯❯❯ npm i -D gulp-svg-sprite@1.2.16 --ignore-scripts
npm ERR! Linux 4.2.0-18-generic
npm ERR! argv "/home/michael-heuberger/.nvm/versions/node/v4.2.2/bin/node" "/home/michael-heuberger/.nvm/versions/node/v4.2.2/bin/npm" "i" "-D" "gulp-svg-sprite@1.2.16" "--ignore-scripts"
npm ERR! node v4.2.2
npm ERR! npm  v2.14.7

npm ERR! version not found: gulp-svg-sprite@1.2.16
npm ERR! 
...

@jkphl
Copy link
Collaborator

jkphl commented Dec 1, 2015

Strange! npmjs.org says the module has been published normally, and I'm able to do a regular install (without explicitely specifying the version; npm v3.3.6, node v5.0.0). Any changes you've got a problem with your Node installation?

@binarykitchen
Copy link
Author

ah, i found the cause. our internal npm proxy had too high cache settings. manually expired these and then it worked. sorry.

@jkphl
Copy link
Collaborator

jkphl commented Dec 1, 2015

Ah, no problem. Glad it works now! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants