Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove width and height on shape missing in latest version #152

Closed
Yoksy opened this issue Apr 8, 2016 · 1 comment
Closed

Remove width and height on shape missing in latest version #152

Yoksy opened this issue Apr 8, 2016 · 1 comment
Assignees

Comments

@Yoksy
Copy link

Yoksy commented Apr 8, 2016

Hello,

on january 28 2015 on issue #45 you had add theses lines in shape.js (commit 4e486dd )

// Remove dimension attributes if not requested
if (!this.config.dimension.attributes) {
svg.removeAttribute('width');
svg.removeAttribute('height');
}

However in the lastest version its seems it was removed. I'm using gulp-svg-sprite and if I don't add these lines, even if in my original svg I remove the width and height dimensions, the plugin generate the sprite with these attributes.

Could you please look into this ? Thanks.

@jkphl jkphl self-assigned this May 14, 2016
@jkphl
Copy link
Collaborator

jkphl commented May 14, 2016

@Yoksy, the old shape.dimension.attributes setting has been replaced by svg.dimensionAttributes with commit 1de2822. Please see here for documentation on how to use it.

@jkphl jkphl closed this as completed May 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants