Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test are failing on Node.js > 10 #302

Closed
mojoaxel opened this issue Dec 2, 2019 · 4 comments
Closed

Test are failing on Node.js > 10 #302

mojoaxel opened this issue Dec 2, 2019 · 4 comments

Comments

@mojoaxel
Copy link
Contributor

mojoaxel commented Dec 2, 2019

I have two failing test in the current master (304a347):

  • svg-sprite | with minimum configuration and 11 SVG files | in «css» mode and all render types | enabled | creates visually correct sprite with | packed layout
  • svg-sprite | with minimum configuration and 11 SVG files | in «view» mode | creates visually correct sprite with | packed layout

expected

image

current

image

  • OS: Ubuntu Linux 64 18.04
  • node: v11.15.0
  • npm: 6.13.0
@XhmikosR
Copy link
Member

I recently spent some time with svg-sprite and for some reason, Node.js > 10 generates a different image. The order seems different.

If you pinpoint the root cause please let me know. In the meantime, I added a different image for Node.js > 10, but that's for making CI happy since I don't know the root cause either. #378

@XhmikosR
Copy link
Member

Do you hit this issue in your puppeteer branch too?

The order seems to change starting from Node.js 12 and on.

@XhmikosR XhmikosR changed the title Test are failing Test are failing on Node.js > 10 Feb 28, 2021
@XhmikosR
Copy link
Member

XhmikosR commented Feb 28, 2021

@mojoaxel please see the discussion in #398 (comment)

Maybe you can figure out a fix faster :)

EDIT: I think I'll just land the different test image on Node.js > 10 and be done with it.

@XhmikosR
Copy link
Member

Merged #398 so this should work on non-Windows machines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants