Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modern JS already guarantees Array#sort() is a stable sort and stable is deprecated #1689

Closed
coderaiser opened this issue Jul 12, 2022 · 9 comments
Labels

Comments

@coderaiser
Copy link

Describe the bug

warning react-scripts > css-minimizer-webpack-plugin > cssnano > cssnano-preset-default > postcss-svgo > svgo > stable@0.1.8: Modern JS already guarantees Array#sort() is a stable sort, so this library is deprecated. See the compatibility table on MDN: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort#browser_compatibility

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • SVGO Version [e.g. 2.0.3]
  • NodeJs Version [e.g 14.0.4]
  • OS: [e.g. iOS]

Additional context
Add any other context about the problem here.

@kevinkhill
Copy link

Someone already did the work! 🎉 #1681

We just need the PR to be merged

@zdm
Copy link

zdm commented Aug 28, 2022

Hey, man. sre you alive?
You make us suffer.

@mahnunchik
Copy link

Any news?

@GamerBene19
Copy link

I might be misunderstanding something here, but should this package not have received a version bump once 2ea6586 was merged?

Currently I have installed svgo v2.8.0 but it still has the old stable "^0.1.8" dependency - how should yarn (in my case) know that that dependency is not needed anymore when stable svgo did not have a version bump?

@andersk
Copy link

andersk commented Oct 17, 2022

@GamerBene19 The main branch is 44 commits ahead of the v2.8.0 release: v2.8.0...main. This fix will be included in the next release when it’s released, not retroactively in the existing release. This is how software development normally works.

@GamerBene19
Copy link

@GamerBene19 The main branch is 44 commits ahead of the v2.8.0 release: v2.8.0...main. This fix will be included in the next release when it’s released, not retroactively in the existing release. This is how software development normally works.

Makes sense, thanks for the explanation!

@mahnunchik
Copy link

So we are looking forward for the next release...

@rodoabad
Copy link

w00t w00t! Thanks for the merge peeps!

@TrySound
Copy link
Member

Fixed in https://github.com/svg/svgo/releases/tag/v3.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants