Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the default config file to not be a hidden dotfile #672

Closed
erkiesken opened this issue Feb 28, 2017 · 3 comments
Closed

Rename the default config file to not be a hidden dotfile #672

erkiesken opened this issue Feb 28, 2017 · 3 comments

Comments

@erkiesken
Copy link

It would be great if the default config file would not be a .svgo.yml hidden dotfile. Talking about this:

defaults = EXTEND({}, yaml.safeLoad(FS.readFileSync(__dirname + '/../../.svgo.yml', 'utf8')));

This is causing issues with yarn (yarnpkg/yarn#1051) and in a roundabout way other modules, like extract-text-webpack-plugin (webpack-contrib/extract-text-webpack-plugin#352 (comment)).

@erkiesken
Copy link
Author

Also was covered a bit in #622 without resolving it.

@GreLI
Copy link
Member

GreLI commented Mar 11, 2017

Dotfiles for configs is a like common convention. I believe, yarn should work with such a files properly.

@TrySound
Copy link
Member

v2 supports only svgo.config.js. No more hidden files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants