Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve unpack_bits #165

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Improve unpack_bits #165

merged 1 commit into from
Jun 18, 2024

Conversation

svilupp
Copy link
Owner

@svilupp svilupp commented Jun 18, 2024

  • Improved the implementation of RAGTools.unpack_bits to be faster with fewer allocations (relevant for BitPackedCosineSimilarity)

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.43%. Comparing base (eff6682) to head (61468e8).

Files Patch % Lines
src/Experimental/RAGTools/utils.jl 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #165      +/-   ##
==========================================
- Coverage   92.53%   92.43%   -0.10%     
==========================================
  Files          44       44              
  Lines        3605     3571      -34     
==========================================
- Hits         3336     3301      -35     
- Misses        269      270       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@svilupp svilupp merged commit 4c6a4d0 into main Jun 18, 2024
4 of 6 checks passed
@svilupp svilupp deleted the bitpacked-rag-performance branch June 18, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant