Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rag Tools fix + relaxing const for API key loading #170

Merged
merged 5 commits into from
Jun 26, 2024
Merged

Conversation

svilupp
Copy link
Owner

@svilupp svilupp commented Jun 26, 2024

  • Fixed loading RAGResult when one of the candidate fields was nothing.
  • Utility type checks like isusermessage, issystemmessage, isdatamessage, isaimessage, istracermessage do not throw errors when given any arbitrary input types (previously they only worked for AbstractMessage types). It's a isa check, so it should work for all input types.
  • Changed preference loading to use typed global instead of const, to fix issues with API keys not being loaded properly on start.

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.19%. Comparing base (da4089f) to head (de5c780).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #170      +/-   ##
==========================================
- Coverage   92.37%   92.19%   -0.19%     
==========================================
  Files          44       44              
  Lines        3622     3653      +31     
==========================================
+ Hits         3346     3368      +22     
- Misses        276      285       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@svilupp svilupp merged commit a649431 into main Jun 26, 2024
5 of 6 checks passed
@svilupp svilupp deleted the rag-tools-fix branch June 26, 2024 09:26
@svilupp svilupp mentioned this pull request Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant