Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Improve AICode to capture more unsafe behaviors #98

Open
2 tasks
svilupp opened this issue Mar 20, 2024 · 3 comments
Open
2 tasks

[FR] Improve AICode to capture more unsafe behaviors #98

svilupp opened this issue Mar 20, 2024 · 3 comments

Comments

@svilupp
Copy link
Owner

svilupp commented Mar 20, 2024

It would be good to capture other unsafe behavior before we evaluate any code

  • file system manipulation (eg, cp, rm`,...)
  • spawning separate processes (eg, run, Cmd)
@jpsamaroo
Copy link

Probably a better approach would be to run the AI within a virtual machine or Docker container, so that we don't have to guard against dangerous behavior (which is an impossible thing to do robustly, without relying on hardware-based or OS-based isolation). We can always do explicit file copies to/from the machine or do volume mapping so that the AI can modify files on the host system.

@svilupp
Copy link
Owner Author

svilupp commented Apr 29, 2024

I 100% agree, or a cloud container like: https://e2b.dev/ (they are becoming really popular).

But I'd say that's out-of-scope for PT to manage. The above is just a 80/20 solution.

Tbf, I'm not sure how that would be managed.. Probably easiest to just connect into the container shell and run PT in there (ie, no work required).

@jpsamaroo
Copy link

I agree that it would be out-of-scope for PT to manage the VM, but I could see it being worthwhile for PT to provide a way to override just directly executing the code in the current session, so another package could implement a VM and then be "plugged in" to PT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants