Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credit to involution #7

Closed
d-li14 opened this issue Aug 8, 2021 · 2 comments
Closed

Credit to involution #7

d-li14 opened this issue Aug 8, 2021 · 2 comments

Comments

@d-li14
Copy link

d-li14 commented Aug 8, 2021

The CUDA kernel of basic op seems to be borrowed from https://github.com/d-li14/involution, especially implied by https://github.com/svip-lab/AS-MLP/blob/main/models/shift_cuda.py#L169.

Please consider properly giving credit to the involution repo and citing us. Thanks.

@niujinshuchong
Copy link
Collaborator

niujinshuchong commented Aug 8, 2021

@d-li14 Sorry for the missing credit and the repo is updated. Thank you very much for your work.

@d-li14 d-li14 closed this as completed Aug 8, 2021
@dongzelian
Copy link
Collaborator

@d-li14 Hi, we will also cite it in the next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants