Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SETTINGS_MANAGER] Add possibility to check arithmetic types settings against set of allowed range of values #92

Closed
svlad-90 opened this issue Aug 12, 2020 · 0 comments · Fixed by #94
Closed

[SETTINGS_MANAGER] Add possibility to check arithmetic types settings against set of allowed range of values #92

svlad-90 opened this issue Aug 12, 2020 · 0 comments · Fixed by #94
Assignees
@svlad-90
Labels
enhancement New feature or request in_ram_cache Issue is related to the [IN_RAM_CACHE] domain settings_manager Issue is related to the [SETTINGS_MANAGER] domain
Projects
DLTMessageAnalyzer
Milestone
v.1.0.24

Comments

@svlad-90
Copy link
Owner

svlad-90 commented Aug 12, 2020 •
edited
Loading

Related to the issue - #16
In order to have a check of RAM cache size on each start-up, we need to do a modification of the settings manager. For arithmetic types, it should take a range of allowed values as an additional input parameter and check persisted value against the range.

  • If the persisted value is less than the minimum value from the range - persisted value should be implicitly exchanged to the minimum allowed one.
  • If the persisted value is more than the maximum value from the range - persisted value should be implicitly exchanged to the maximum allowed one.
@svlad-90 svlad-90 added enhancement New feature or request in_ram_cache Issue is related to the [IN_RAM_CACHE] domain labels Aug 12, 2020
@svlad-90 svlad-90 added this to the v.1.0.24 milestone Aug 12, 2020
@svlad-90 svlad-90 added this to To do in DLTMessageAnalyzer via automation Aug 12, 2020
@svlad-90 svlad-90 self-assigned this Aug 12, 2020
@svlad-90 svlad-90 added the settings_manager Issue is related to the [SETTINGS_MANAGER] domain label Aug 12, 2020
@svlad-90 svlad-90 mentioned this issue Aug 12, 2020
Closed
@svlad-90 svlad-90 changed the title [SETTINGS_MANAGER] Add possibility to check integral settings against set of allowed range of values [SETTINGS_MANAGER] Add possibility to check arithmetic types settings against set of allowed range of values Aug 13, 2020
@svlad-90 svlad-90 moved this from To do to In progress in DLTMessageAnalyzer Aug 13, 2020
svlad-90 added a commit that referenced this issue Aug 14, 2020
@svlad-90
[ISSUE #92][SETTINGS_MANAGER] Add possibility to check arithmetic typ…
1e04106 
…es settings against set of allowed range of values

1. [X] Have you followed the guidelines in our [Contributing document](../blob/master/CONTRIBUTING.md)?
2. [X] Have you checked to ensure there aren't other open [Pull Requests](../pulls) for the same update/change?
3. [X] Have you built the project, and performed manual testing of your functionality for all supported platforms - Linux and Windows?
4. [X] Is your change backward-compatible with the previous version of the plugin?

>>> Change description:

- Introduction of the TOptional template class
- Refactoring of the tRange to become a template class
- Separation of cpp_standard extensions to the separate header
- Implementation of the ranged-based settings
- Switch of "NumberOfThreads" & "CacheMaxSizeMB" to the range-based ones
- Modification of README to reflect newly added logic

>>> Verification criteria:

- Implementation was checked manually on Windows and Linux
- All sanity checks on Git hub were passed
@svlad-90 svlad-90 mentioned this issue Aug 14, 2020
Merged
4 tasks
svlad-90 added a commit that referenced this issue Aug 14, 2020
@svlad-90
[ISSUE #92][SETTINGS_MANAGER] Add possibility to check arithmetic typ…
d82ae4c 
…es settings against set of allowed range of values

1. [X] Have you followed the guidelines in our [Contributing document](../blob/master/CONTRIBUTING.md)?
2. [X] Have you checked to ensure there aren't other open [Pull Requests](../pulls) for the same update/change?
3. [X] Have you built the project, and performed manual testing of your functionality for all supported platforms - Linux and Windows?
4. [X] Is your change backward-compatible with the previous version of the plugin?

>>> Change description:

- Introduction of the TOptional template class
- Refactoring of the tRange to become a template class
- Separation of cpp_standard extensions to the separate header
- Implementation of the ranged-based settings
- Switch of "NumberOfThreads" & "CacheMaxSizeMB" to the range-based ones
- Modification of README to reflect newly added logic

>>> Verification criteria:

- Implementation was checked manually on Windows and Linux
- All sanity checks on Git hub were passed
@svlad-90 svlad-90 linked a pull request Aug 14, 2020 that will close this issue
[ISSUE #92][SETTINGS_MANAGER] Add possibility to check arithmetic types settings against set of allowed range of values #94
Merged
4 tasks
DLTMessageAnalyzer automation moved this from In progress to Done Aug 14, 2020
svlad-90 added a commit that referenced this issue Aug 14, 2020
@svlad-90
Merge pull request #94 from svlad-90/feature/ISSUE_92
a8daea4 
[ISSUE #92][SETTINGS_MANAGER] Add possibility to check arithmetic types settings against set of allowed range of values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@svlad-90 svlad-90

Labels
enhancement New feature or request in_ram_cache Issue is related to the [IN_RAM_CACHE] domain settings_manager Issue is related to the [SETTINGS_MANAGER] domain
Projects
DLTMessageAnalyzer
  
Done
Milestone
v.1.0.24
1 participant
@svlad-90