Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused fields from models #342

Open
DeD1rk opened this issue Feb 12, 2023 · 1 comment
Open

Remove unused fields from models #342

DeD1rk opened this issue Feb 12, 2023 · 1 comment
Labels
chore Something that is not a bug or a feature, does not change production behaviour easy and fun Good for newcomers priority: medium A new feature or a bugfix that is non-critical.

Comments

@DeD1rk
Copy link
Member

DeD1rk commented Feb 12, 2023

What

Some models may include fields that are currently returned by the API, but that we don't use. Those should be removed, so that the app keeps working even if the fields are removed from the API.

Why

As of svthalia/concrexit#2796 (and probably some other similar changes to decouple concrexit's apps), events will no longer have a slide field. IIRC reaxit tries to parse that field but doesn't use it. If we don't change reaxit not to try parsing such fields, it might break with future versions of concrexit.

How

Check for any fields that don't seem useful, check that they're not used, and remove them. Then run build_runner again to update the model generated code.

@DeD1rk DeD1rk added chore Something that is not a bug or a feature, does not change production behaviour easy and fun Good for newcomers priority: high Must be dealt with before the next release is deployed. labels Feb 12, 2023
@DeD1rk
Copy link
Member Author

DeD1rk commented Mar 3, 2023

I just checked that slides aren't parsed so that's no problem. So there might not actually be anything that really needs to be changed.

@DeD1rk DeD1rk added priority: medium A new feature or a bugfix that is non-critical. and removed priority: high Must be dealt with before the next release is deployed. labels Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Something that is not a bug or a feature, does not change production behaviour easy and fun Good for newcomers priority: medium A new feature or a bugfix that is non-critical.
Projects
None yet
Development

No branches or pull requests

1 participant