Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcut action not working on Crome/Firefox Win 10 #24

Closed
daevid66 opened this issue May 10, 2021 · 3 comments
Closed

Shortcut action not working on Crome/Firefox Win 10 #24

daevid66 opened this issue May 10, 2021 · 3 comments

Comments

@daevid66
Copy link

Hi, it seems like the key combo you selected in your second example does not work on Windows browsers.

From experimentation I've found that e.altKey and e.shiftKey are both false when also pressing the 2 key (or any other number key).

In contrast, all the following combinations DO work as expected:
Ctrl+2
Alt+2
Shift+Alt+2
Shift+Ctrl+2
Alt+Ctrl+E (or any other non-numerical key I've tried)

This seems very bizarre to me. I'm using a Swedish keyboard but I have not seen any problem like this before. My guess is that it's a Windows issue.

Maybe it's an ok solution to simply change the used combo in the example, and add a comment on this issue in the action description + code?

Cheers,

/David

@swyxio
Copy link
Owner

swyxio commented May 10, 2021

yikes! happy to do that, want to PR?

@daevid66
Copy link
Author

Hi, the problem is the demo REPL, so I don't think I can do a PR for that.

I would change the following element:

		<td use:shortcut={{shift:true, control: true, code: 'KeyE', callback: () => divCount++}}>
			Will trigger a callback (Cmd/Ctrl + Shift + E)
		</td>

@swyxio
Copy link
Owner

swyxio commented May 17, 2021

@swyxio swyxio closed this as completed in 1729a5f May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants