Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add sourceDescription to ns-workflows-1 #3403

Merged
merged 6 commits into from
Nov 20, 2023
Merged

feat: Add sourceDescription to ns-workflows-1 #3403

merged 6 commits into from
Nov 20, 2023
+322 −10

Conversation

frankkilcommins
Copy link
Collaborator

Refs: #3392

Add SourceDescription object to apidom-ns-workflows-1

@frankkilcommins frankkilcommins added enhancement New feature or request ApiDOM Workflows Workflows specification labels Nov 16, 2023
@char0n char0n self-assigned this Nov 16, 2023
char0n
char0n requested changes Nov 16, 2023
View reviewed changes
Copy link
Member

@char0n char0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Some changes needed before the merge

packages/apidom-ns-workflows-1/src/traversal/visitor.ts Outdated Show resolved Hide resolved
packages/apidom-ns-workflows-1/src/refractor/visitors/workflows-1/sourceDescription/index.ts Outdated Show resolved Hide resolved
packages/apidom-ns-workflows-1/src/elements/WorkflowsSpecification1.ts Show resolved Hide resolved
packages/apidom-ns-workflows-1/src/elements/WorkflowsSpecification1.ts Show resolved Hide resolved
packages/apidom-ns-workflows-1/src/refractor/specification.ts Outdated Show resolved Hide resolved
packages/apidom-ns-workflows-1/src/refractor/predicates.ts Outdated Show resolved Hide resolved
packages/apidom-ns-workflows-1/src/refractor/visitors/workflows-1/SourceDescriptionsVisitor.ts Outdated Show resolved Hide resolved
...es/apidom-ns-workflows-1/src/refractor/visitors/workflows-1/sourceDescription/TypeVisitor.ts Outdated Show resolved Hide resolved
char0n
char0n approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@char0n char0n left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left 1 comment to possibly look at before the merge.

packages/apidom-ns-workflows-1/test/predicates.ts Show resolved Hide resolved
packages/apidom-ns-workflows-1/src/elements/WorkflowsSpecification1.ts Show resolved Hide resolved
packages/apidom-ns-workflows-1/src/elements/WorkflowsSpecification1.ts Show resolved Hide resolved
char0n
char0n approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@char0n char0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the test @frankkilcommins!

@char0n char0n merged commit 893f125 into swagger-api:main Nov 20, 2023
8 checks passed
@frankkilcommins frankkilcommins deleted the ns-workflows-1-sourceDescriptions branch December 13, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@char0n char0n char0n approved these changes

Assignees

@char0n char0n

Labels
ApiDOM enhancement New feature or request Workflows Workflows specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@frankkilcommins @char0n