feat(converter): add Reference Object summary and description plugins #3885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
char0n
changed the title
char0n
reviewed
Mar 4, 2024
...c/strategies/openapi-3-1-to-openapi-3-0-3/refractor-plugins/reference-summary-description.ts
Outdated
Show resolved
Hide resolved
|
@tekyu there is an option to have this plugin divided into two. One plugin that removes summary, one that removes description. The idea is that every plugin just handles one aspect of the the transformation. In this particular case, we can say that the aspect is to remove the non-supported fields, or we can divide the aspect into two separate ones. Please let me know what you think. |
|
@char0n if the idea is to have plugins that handles single operation I don't want to disrupt that with my plugin. I'll split them then |
|
@tekyu it's your decision, as for this particular one I don't have strong opinion. |
tekyu
force-pushed
the
feat/reference-summary-description-plugin
branch
from
9b67ab6
to
f942461
Compare
tekyu
changed the title
char0n
reviewed
Mar 4, 2024
...erter/src/strategies/openapi-3-1-to-openapi-3-0-3/refractor-plugins/reference-description.ts
Outdated
Show resolved
Hide resolved
char0n
reviewed
Mar 4, 2024
...converter/src/strategies/openapi-3-1-to-openapi-3-0-3/refractor-plugins/reference-summary.ts
Outdated
Show resolved
Hide resolved
char0n
approved these changes
Mar 4, 2024
char0n
changed the title
tekyu
force-pushed
the
feat/reference-summary-description-plugin
branch
from
f942461
to
9f14db7
Compare
|
@tekyu plese use Please also use commit message format described in: #3848 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
his plugin removes the
summaryanddescriptionfields ofReference Object.Refs SWG-10235
Refs #3697