Objc header param with hyphen generates broken methods

[hyeghiazaryan]

This fragment of config

parameters: [
  {
    name: "custom-header",
    in: "header",
    required: true,
    type: "string"
  }
]

Generates this code in .h file

-(NSNumber*) deleteEntityWithCompletionBlock :(NSString*) entity custom-header:(NSString*) custom-header completionHandler: (void (^)(SWGOperationResult* output, NSError* error))completionBlock;

Note hyphens in method signature.

[fehguy]

That's a bug, easy to fix. I suggest adding this to the languages/ObjClientCodegen.java:

  @Override
  public String toVarName(String name) {
    // replace - with _ e.g. created-at => created_at
    name = name.replaceAll("-", "_");

    // if it's all uppper case, do nothing
    if (name.matches("^[A-Z_]*$"))
      return name;

    // camelize (lower first character) the variable name
    // pet_id => petId
    name = camelize(name, true);

    // for reserved word or word starting with number, append _
    if(reservedWords.contains(name) || name.matches("^\\d.*"))
      name = escapeReservedWord(name);

    return name;
  }

And report back.

[hyeghiazaryan]

toVarName override already exists in languages/ObjClientCodegen.java, toParamName was the one missing.

[webron]

This is resolved in develop_2.0.