Issue with typescript-jquery generator returned promise type

[baol]

Description

I was not able to use the typescript-jquery bindings in vscode or compile a simple application using them.

    someApi.someMethod().then( (result) => console.log(result.body));

The generated code looks like:

    let dfd = $.Deferred();
    $.ajax(requestOptions).then(
        (data: models.Operation, textStatus: string, jqXHR: JQueryXHR) =>
            dfd.resolve(jqXHR, data),
        (xhr: JQueryXHR, textStatus: string, errorThrown: string) =>
            dfd.reject(xhr, errorThrown)
    );
    return dfd.promise();

While my new-to-the-topic opinion is that it should look more like:

    let dfd = $.Deferred();
    $.ajax(requestOptions).then(
        (data: models.Operation, textStatus: string, jqXHR: JQueryXHR) =>
            dfd.resolve({ request: jqXHR, body: data }),
        (xhr: JQueryXHR, textStatus: string, errorThrown: string) =>
            dfd.reject({ request: xhr, body: errorThrown})
    );
    return dfd.promise();

Given that the signature of the generated method is:

public someMethod(): JQueryPromise<{ response: JQueryXHR; body: models.Operation;  }>

Not sure about the reject part, but both the compiler and intellisense are happier.

Swagger-codegen version

2.3.1 and 2.4.0-20180627.132127-273

Using jquery 3.1.1, with @types/jquery 3.3.4

Command line used for generation

swagger-codegen generate -l typescript-jquery -i ... -o ...

Note

It may very well be that I'm doing something wrong, in which case I'd suggest to maybe add some examples on how to call the generated code (either in a comment of the generated code, or in a separate example).

[baol]

Hi @macjohnny, I noticed you took care of a few typescript related pr in the past, would you have a look here?

[rahulbpatel]

What's the word on fixing this in swagger-codegen? Looks like it was already closed in openapi-generator.