Adding Extensions in Responses (OAS2) #2835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frantuma
reviewed
Jun 27, 2018
| public Operation response(int key, Response response) { | ||
| this.addResponse(String.valueOf(key), response); | ||
| this.addResponse(String.valueOf(key),response); |
| public Operation defaultResponse(Response response) { | ||
| this.addResponse("default", response); | ||
| this.addResponse("default",response); |
| @@ -209,16 +213,53 @@ public void addParameter(Parameter parameter) { | |||
| } | |||
| this.parameters.add(parameter); | |||
| } | |||
|
|
|||
| @Deprecated | |||
There was a problem hiding this comment.
remove this, as deprecation comes from mixin
| public Map<String, Response> getResponses() { | ||
| return responses; | ||
| } | ||
|
|
||
| public Responses getResponsesObject() { return responsesObject; } | ||
|
|
||
| @Deprecated |
There was a problem hiding this comment.
remove this, as deprecation comes from mixin
| public Map<String, Response> getResponses() { | ||
| return responses; | ||
| } | ||
|
|
||
| public Responses getResponsesObject() { return responsesObject; } |
There was a problem hiding this comment.
this needs to return responsesObject (converted to Map) or responses depending on null status of the two. see how this is achieved for responseSchema and schema in response
| public void addResponse(String key, Response response) { | ||
| if (responses == null) { |
| } | ||
| } | ||
|
|
||
| @Deprecated |
| responsesObject.put(key, response); | ||
| } | ||
|
|
||
| public void addResponseObject(String key, Response response) { |
| @@ -103,7 +103,7 @@ public Swagger path(String key, Path path) { | |||
| return this; | |||
| } | |||
|
|
|||
| public Swagger responses(Map<String, Response> responses) { | |||
| public Swagger responses(LinkedHashMap<String, Response> responses) { | |||
There was a problem hiding this comment.
why is this? keep it instead as Map
| @@ -375,7 +375,7 @@ public void addParameter(String key, Parameter parameter) { | |||
| return responses; | |||
| } | |||
|
|
|||
| public void setResponses(Map<String, Response> responses) { | |||
| public void setResponses(LinkedHashMap<String, Response> responses) { | |||
There was a problem hiding this comment.
why is this? keep it instead as Map
…o responses-extensions-OAS2
gracekarina
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs issue #719