Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop 2.0] ensure composition support is correct #802

Closed
fehguy opened this issue Dec 22, 2014 · 2 comments
Closed

[develop 2.0] ensure composition support is correct #802

fehguy opened this issue Dec 22, 2014 · 2 comments
Assignees
Labels
Milestone

Comments

@fehguy
Copy link
Contributor

fehguy commented Dec 22, 2014

The support for allOf in model definitions is partially complete--need to ensure that the support follows the design of the 2.0 spec.

See here:

https://github.com/swagger-api/swagger-core/blob/develop_2.0/modules/swagger-core/src/test/scala/CompositionTest.scala

@fehguy fehguy added the Bug label Dec 22, 2014
@fehguy fehguy added this to the v1.5.0-M2 milestone Dec 22, 2014
@fehguy fehguy added the P1 label Dec 23, 2014
@fehguy fehguy self-assigned this Mar 13, 2015
@fehguy fehguy modified the milestones: v1.5-M2, v1.5-M3 Mar 29, 2015
@tomtit
Copy link
Contributor

tomtit commented Apr 8, 2015

The CompositionTest unit test is enabled now and checks the presence of the 'allOf' entry in the model definition. What else should be done to resolve the issue?

@webron webron assigned tomtit and unassigned fehguy Apr 15, 2015
@tomtit
Copy link
Contributor

tomtit commented Apr 15, 2015

The first test for the Human class seems to be incorrect as it accepts Pet as a descendant of Human:

"Pet" : {
    "allOf" : [ {
        "$ref" : "#/definitions/Human"
    }

So, here is an improvement #987 for handling subtypes stricter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants