Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: Disable live autocomplete if it’s affecting the main thread #1311

Closed
webron opened this issue May 2, 2017 · 2 comments
Closed

Feature request: Disable live autocomplete if it’s affecting the main thread #1311

webron opened this issue May 2, 2017 · 2 comments
Assignees
@shockey
Labels
P1 type: feature version: 3.x

Comments

@webron
Copy link
Contributor

webron commented May 2, 2017 •
edited by shockey

  • Disable as-you-type autocomplete if it takes more than 100ms.
  • When disabled, keep an eye on the performance of manually-triggered autocomplete, and if that falls below 100ms, re-enable the live autocomplete.
@shockey shockey added the Ready label May 10, 2017
@grosch grosch mentioned this issue Jun 13, 2017
Closed
@shockey shockey added In progress and removed Ready labels Jul 18, 2017
@ponelat
Copy link
Member

ponelat commented Jul 18, 2017

We have a plugin, that can disable live autocomplete. It doesn't do the timeout thing ( ie: if longer than 200ms, or something ). Its just a config you can toggle with configsActions.toggle('editorLiveAutocomplete'). @shockey ping if you'd like to know MOAR.

@shockey shockey mentioned this issue Jul 25, 2017
Merged
@shockey
Copy link
Contributor

shockey commented Jul 28, 2017

Implemented 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shockey shockey

Labels
P1 type: feature version: 3.x
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@webron @shockey @ponelat