Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop 2.0] merge 1.x client with 2.0 #182

Closed
fehguy opened this issue Dec 24, 2014 · 1 comment
Closed

[develop 2.0] merge 1.x client with 2.0 #182

fehguy opened this issue Dec 24, 2014 · 1 comment
Milestone

Comments

@fehguy
Copy link
Contributor

fehguy commented Dec 24, 2014

Currently the master branch for swagger-js supports 1.0, 1.1, 1.2 swagger spec versions. The develop_2.0 branch supports the 2.0 spec only. For a client like swagger-ui supporting all versions of swagger, the process is to include the swagger.js (from master, currently 2.0.47) and the new version of swagger client (named swagger-client.js), and determine which to use at runtime. That's pretty ghetto.

The old and new versions have different namespaces, and can live in a single file. Would like to both (a) have a better process to separate the code between versions, and (b) let the swagger-js client determine which version to use when it's invoked, taking the logic out of the caller.

In all cases, it makes sense to have a single swagger-js file containing both sets of logic.

@fehguy fehguy modified the milestones: 2.1-M1, 2.1-M2 Dec 24, 2014
@fehguy
Copy link
Contributor Author

fehguy commented Jan 27, 2015

addressed in 5b60f2a

@fehguy fehguy closed this as completed Jan 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant