Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spec actions are storing data in resolved key #3700

Closed
shockey opened this issue Sep 23, 2017 · 2 comments
Closed

Spec actions are storing data in resolved key #3700

shockey opened this issue Sep 23, 2017 · 2 comments
Labels
locked-by: lock-bot Nice to have type: enhancement

Comments

@shockey
Copy link
Contributor

shockey commented Sep 23, 2017 •
edited

Some spec actions are storing their data inside of the resolved spec state key, which is a rather messy way to keep up with things, and breaks the idea of each piece of state handling a single concern.

For example, after changing the content type of a request body, consumes_value and produces_value are set:

messages image 308353254

Any reducers and selectors that add or mutate non-spec data under the resolved key should be refactored to have their own key - resolved should be only the result of swagger-client resolving the specJson data.
@shockey
Copy link
Contributor Author

shockey commented Jul 5, 2018

Most likely resolved, but needs review

@shockey
Copy link
Contributor Author

shockey commented Jul 9, 2018

This is resolved: only UPDATE_RESOLVED mutates spec.resolved now.

@shockey shockey closed this as completed Jul 9, 2018
@lock lock bot locked and limited conversation to collaborators Jul 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
locked-by: lock-bot Nice to have type: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shockey