Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Low visibility of headers in markdown tables #3897

Closed
hugo19941994 opened this issue Nov 13, 2017 · 1 comment · Fixed by #3909
Closed

Low visibility of headers in markdown tables #3897

hugo19941994 opened this issue Nov 13, 2017 · 1 comment · Fixed by #3909

Comments

@hugo19941994
Copy link
Contributor

hugo19941994 commented Nov 13, 2017

Hi!

Since version 3.3.2 (3.3.1 works fine) the headers of tables inside the response description fields can barely be seen.

I think this behavior changed after commit 2cd4989

Q A
Bug or feature request? Bug
Which Swagger/OpenAPI version? 2.0, maybe 3.0
Which Swagger-UI version? 3.3.2+
How did you install Swagger-UI? Manually
Which browser & version? Chrome 62
Which operating system? Linux

Demonstration API definition

400:
  description:
    | Error Code | Description                                          |
    | --------------- | ---------------------------------------------------- |
    | 1                | Missing X-Client-Code request header |

Expected Behavior

3-3-1

Current Behavior

3-3-2

Possible Solution

Can be quickly fixed by changing the layout SCSS file. Just make th white inside .response-col_description__inner

https://github.com/hugo19941994/swagger-ui/commit/9dac9f348400fe859ee7738ea42a433c194b898f

fix

@hugo19941994
Copy link
Contributor Author

Thanks for taking a look @owenconti !

I realised today that the horizontal bar which separates the headers has bad visibility too. I've sent an alternative PR to yours which also sets the bar to the same color as the text.

@lock lock bot unassigned owenconti Jul 2, 2019
@lock lock bot locked and limited conversation to collaborators Jul 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants